feat(datasets): create separate ibis.FileDataset
#842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepyaman
force-pushed
the
feat/datasets/ibis-filedataset
branch
7 times, most recently
from
88f74cb
to
c8f076e
Compare
Closed
deepyaman
force-pushed
the
feat/datasets/ibis-filedataset
branch
from
f5436cb
to
af42be8
Compare
|
One of the downsides of having a separate I can explore this in a future PR; this is probably good enough for now. |
deepyaman
force-pushed
the
feat/datasets/ibis-filedataset
branch
2 times, most recently
from
ad21e5a
to
fe56964
Compare
4 tasks
noklam
reviewed
Oct 8, 2024
datajoely
reviewed
Oct 8, 2024
datajoely
previously requested changes
Oct 8, 2024
There was a problem hiding this comment.
This is 99% there, I'd prefer some extra bits of clarity so that @deepyaman 's bus factor isn't as high when it comes to maintainability
Very excited to get this in 💪
deepyaman
force-pushed
the
feat/datasets/ibis-filedataset
branch
2 times, most recently
from
ff0b85a
to
bce8c57
Compare
deepyaman
commented
Oct 10, 2024
deepyaman
force-pushed
the
feat/datasets/ibis-filedataset
branch
from
2aa5bcc
to
27a4f4b
Compare
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Refs: b7ff0c7 Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
force-pushed
the
feat/datasets/ibis-filedataset
branch
from
27a4f4b
to
b43163e
Compare
noklam
approved these changes
Oct 11, 2024
tdhooghe
pushed a commit
to tdhooghe/kedro-plugins
that referenced
this pull request
Oct 21, 2024
* feat(datasets): create separate `ibis.FileDataset` Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): deprecate `TableDataset` file I/O Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * feat(datasets): implement `FileDataset` versioning Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): try `os.path.exists`, for Windows Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * revert(datasets): use pathlib, ignore Windows test Refs: b7ff0c7 Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * docs(datasets): add `ibis.FileDataset` to contents Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): add docstring for `hashable` func Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): add docstring for `hashable` func Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * feat(datasets)!: expose `load` and `save` publicly Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): remove second filepath assignment Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: tdhooghe <thomas_dhooghe@mckinsey.com>
tdhooghe
pushed a commit
to tdhooghe/kedro-plugins
that referenced
this pull request
Oct 21, 2024
* feat(datasets): create separate `ibis.FileDataset` Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): deprecate `TableDataset` file I/O Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * feat(datasets): implement `FileDataset` versioning Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): try `os.path.exists`, for Windows Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * revert(datasets): use pathlib, ignore Windows test Refs: b7ff0c7 Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * docs(datasets): add `ibis.FileDataset` to contents Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): add docstring for `hashable` func Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): add docstring for `hashable` func Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * feat(datasets)!: expose `load` and `save` publicly Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): remove second filepath assignment Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: tdhooghe <thomas_dhooghe@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #828
Development notes
So far, I copied
ibis.TableDataset, removing code paths for reading database tables, and adding support for file export.Just wanted to put this out there for early feedback, but what else should be done?
TableDatasetFileDataset)FileDatasetto toctree, etc.)Update: Versioning is actually not a trivial subject, because backends don't implement a consistent interface for checking whether a file exists. I plan to do this with PyArrow filesystem, but I will do that in a follow-up PR (to limit complexity added here); this PR handles local versioning.
Checklist
RELEASE.mdfile